Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

usage of ProgressUnknown fixed #720

Merged
merged 4 commits into from
Sep 18, 2023
Merged

usage of ProgressUnknown fixed #720

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3020e8f
usage of ProgressUnknown fixed
yoninazarathy Sep 18, 2023
74dc3e8
whitspace
yoninazarathy Sep 18, 2023
226ba85
Formatting
palday Sep 18, 2023
a91d243
patch bump
palday Sep 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/generalizedlinearmixedmodel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@
optsum.final = copy(optsum.initial)
end
setpar! = fast ? setθ! : setβθ!
prog = ProgressUnknown("Minimizing"; showspeed=true)
prog = ProgressUnknown(; desc = "Minimizing", showspeed=true)

Check warning on line 281 in src/generalizedlinearmixedmodel.jl

View workflow job for this annotation

GitHub Actions / Style Enforcement (Julia 1.6 - pull_request) 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
src/generalizedlinearmixedmodel.jl:281:-    prog = ProgressUnknown(; desc = "Minimizing", showspeed=true)
src/generalizedlinearmixedmodel.jl:281:+    prog = ProgressUnknown(; desc="Minimizing", showspeed=true)
palday marked this conversation as resolved.
Show resolved Hide resolved
# start from zero for the initial call to obj before optimization
iter = 0
fitlog = optsum.fitlog
Expand Down Expand Up @@ -718,7 +718,7 @@
io::IO, ::MIME"text/plain", m::GeneralizedLinearMixedModel{T,D}
) where {T,D}
if m.optsum.feval < 0
@warn("Model has not been fit")

Check warning on line 721 in src/generalizedlinearmixedmodel.jl

View workflow job for this annotation

GitHub Actions / Documentation 

Model has not been fit
return nothing
end
nAGQ = m.LMM.optsum.nAGQ
Expand Down
2 changes: 1 addition & 1 deletion src/linearmixedmodel.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@
end
opt = Opt(optsum)
optsum.REML = REML
prog = ProgressUnknown("Minimizing"; showspeed=true)
prog = ProgressUnknown(; desc = "Minimizing", showspeed=true)

Check warning on line 460 in src/linearmixedmodel.jl

View workflow job for this annotation

GitHub Actions / Style Enforcement (Julia 1.6 - pull_request) 

[JuliaFormatter] reported by reviewdog 🐶


Raw Output:
src/linearmixedmodel.jl:460:-    prog = ProgressUnknown(; desc = "Minimizing", showspeed=true)
src/linearmixedmodel.jl:460:+    prog = ProgressUnknown(; desc="Minimizing", showspeed=true)
palday marked this conversation as resolved.
Show resolved Hide resolved
# start from zero for the initial call to obj before optimization
iter = 0
fitlog = optsum.fitlog
Expand Down
Loading