Replace broadcasted lambda with explicit loop

[palday]

Thanks for contributing!

Did behavior change? Did you add need features? If so, please update NEWS.md

• add entry in NEWS.md
• after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

• I've bumped the version appropriately

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.27%. Comparing base (ee5f2cf) to head (dda6e09).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #738      +/-   ##
==========================================
- Coverage   96.33%   96.27%   -0.06%     
==========================================
  Files          34       34              
  Lines        3353     3356       +3     
==========================================
+ Hits         3230     3231       +1     
- Misses        123      125       +2     

Flag	Coverage Δ
current	96.27% <100.00%> (+<0.01%)	⬆️
minimum	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Benchmark Report for /home/runner/work/MixedModels.jl/MixedModels.jl

Job Properties

• Time of benchmarks:
  • Target: 5 Mar 2024 - 17:23
  • Baseline: 5 Mar 2024 - 17:28
• Package commits:
  • Target: d96239
  • Baseline: ee5f2c
• Julia commits:
  • Target: bd47ec
  • Baseline: bd47ec
• Julia command flags:
  • Target: None
  • Baseline: -C,native,-J/opt/hostedtoolcache/julia/1.10.2/x64/lib/julia/sys.so,-g1,-O3,-e,using Pkg; Pkg.update(); Pkg.add(["BenchmarkTools", "StatsModels"])
• Environment variables:
  • Target: None
  • Baseline: None

Results

A ratio greater than 1.0 denotes a possible regression (marked with ❌), while a ratio less
than 1.0 denotes a possible improvement (marked with ✅). Only significant results - results
that indicate possible regressions or improvements - are shown below (thus, an empty table means that all
benchmark results remained invariant between builds).

ID	time ratio	memory ratio
["crossed", "insteval:2"]	0.89 (5%) ✅	1.00 (1%)
["crossed", "machines:1"]	1.00 (5%)	0.98 (1%) ✅
["crossed", "ml1m:1"]	0.94 (5%) ✅	1.00 (1%)
["crossed", "mrk17_exp1:1"]	0.09 (5%) ✅	1.00 (1%)
["crossed", "penicillin:1"]	1.02 (5%)	0.99 (1%) ✅
["crossedvector", "d3:1"]	0.94 (5%) ✅	1.00 (1%)
["crossedvector", "kb07:3"]	0.46 (5%) ✅	1.00 (1%)
["nested", "pastes:2"]	0.99 (5%)	0.98 (1%) ✅
["singlevector", "sleepstudy:2"]	1.03 (5%)	0.99 (1%) ✅
["singlevector", "sleepstudy:3"]	1.01 (5%)	0.98 (1%) ✅
["singlevector", "sleepstudy:4"]	1.02 (5%)	0.99 (1%) ✅

Benchmark Group List

Here's a list of all the benchmark groups executed by this job:

• ["crossed"]
• ["crossedvector"]
• ["nested"]
• ["singlevector"]

Julia versioninfo

Target

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1015-azure #15~22.04.1-Ubuntu SMP Tue Feb 13 01:15:12 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  2830 MHz       1438 s          0 s        316 s       3230 s          0 s
       #2  2641 MHz       1693 s          0 s        399 s       2896 s          0 s
       #3  3243 MHz       2067 s          0 s        296 s       2614 s          0 s
       #4  2445 MHz       1704 s          0 s        256 s       3026 s          0 s
  Memory: 15.606491088867188 GB (13612.93359375 MB free)
  Uptime: 500.99 sec
  Load Avg:  1.62  1.33  0.71
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

Baseline

Julia Version 1.10.2
Commit bd47eca2c8a (2024-03-01 10:14 UTC)
Build Info:
  Official https://julialang.org/ release
Platform Info:
  OS: Linux (x86_64-linux-gnu)
      Ubuntu 22.04.4 LTS
  uname: Linux 6.5.0-1015-azure #15~22.04.1-Ubuntu SMP Tue Feb 13 01:15:12 UTC 2024 x86_64 x86_64
  CPU: AMD EPYC 7763 64-Core Processor: 
              speed         user         nice          sys         idle          irq
       #1  3251 MHz       2104 s          0 s        455 s       5126 s          0 s
       #2  3243 MHz       2864 s          0 s        693 s       4136 s          0 s
       #3  2445 MHz       3208 s          0 s        392 s       4080 s          0 s
       #4  3207 MHz       3238 s          0 s        360 s       4093 s          0 s
  Memory: 15.606491088867188 GB (13894.74609375 MB free)
  Uptime: 771.86 sec
  Load Avg:  1.59  1.65  1.04
  WORD_SIZE: 64
  LIBM: libopenlibm
  LLVM: libLLVM-15.0.7 (ORCJIT, znver3)
Threads: 1 default, 0 interactive, 1 GC (on 4 virtual cores)

[dmbates]

@palday This looks reasonable. Should we bring it up-to-date with the current main branch and merge it? In other words, is there a reason that you have left this PR as a Draft?

[palday]

@dmbates It was one of a few performance experiments I was doing while waiting for code in other projects to precompile. 😂 I think we can go ahead and merge it if you're happy?