Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A test using a deep copy of a model should reset the initial parameter values. #744

Merged
merged 2 commits into from
Feb 20, 2024

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Feb 18, 2024

Because the initial values for the theta parameters are derived from the values stored in the reterms they will be the final parameter estimates if those terms are deep copied to create a new model.

The NLopt optimizers don't object to this but the PRIMA optimizers do.

Copy link

codecov bot commented Feb 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6fde5ca) 96.33% compared to head (040d50d) 96.33%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #744   +/-   ##
=======================================
  Coverage   96.33%   96.33%           
=======================================
  Files          34       34           
  Lines        3353     3353           
=======================================
  Hits         3230     3230           
  Misses        123      123           
Flag Coverage Δ
current 96.33% <ø> (ø)
minimum 96.23% <ø> (ø)
nightly ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dmbates dmbates requested a review from palday February 19, 2024 14:38
@dmbates
Copy link
Collaborator Author

dmbates commented Feb 19, 2024

The nightly tests are failing consistently on this PR. It appears that the download of the datasets fails when installing MixedModelsDatasets package.

@palday
Copy link
Member

palday commented Feb 20, 2024

The nightly tests are failing consistently on this PR. It appears that the download of the datasets fails when installing MixedModelsDatasets package.

Yeah, I've run into this on other repositories as well and I don't know why it's happening -- I can't replicate with a local nightly build.

@dmbates
Copy link
Collaborator Author

dmbates commented Feb 20, 2024

@palday Okay to merge this PR without bumping the patch number? This only affects a test and doesn't change the result of the test - just the run time.

@palday
Copy link
Member

palday commented Feb 20, 2024

@dmbates Go for merge without patch bump. 😄

@dmbates dmbates merged commit 529c710 into main Feb 20, 2024
10 of 11 checks passed
@dmbates dmbates deleted the db/resetinitial branch February 20, 2024 15:44
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants