Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add precompile step for rePCA #749

Merged
merged 10 commits into from
Sep 3, 2024
Merged

Add precompile step for rePCA #749

merged 10 commits into from
Sep 3, 2024

Conversation

palday
Copy link
Member

@palday palday commented Mar 2, 2024

This will hopefully make it easier to separate compile vs. runtime changes in performance.

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

Copy link

codecov bot commented Mar 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.99%. Comparing base (0ad0594) to head (d203396).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #749   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files          34       34           
  Lines        3361     3361           
=======================================
  Hits         3260     3260           
  Misses        101      101           
Flag Coverage Δ
current 96.93% <ø> (ø)
minimum 96.87% <ø> (-0.03%) ⬇️
nightly 96.50% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

This comment was marked as outdated.

@palday palday marked this pull request as ready for review March 5, 2024 22:20
src/MixedModels.jl Outdated Show resolved Hide resolved
palday and others added 2 commits March 6, 2024 00:35
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@palday palday merged commit 2ed1933 into main Sep 3, 2024
12 checks passed
@palday palday deleted the pa/pca_precomp branch September 3, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants