Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use ::Matrix{T} instead of ::T to aid type inference #773

Merged
merged 3 commits into from
Jun 22, 2024
Merged

Conversation

dmbates
Copy link
Collaborator

@dmbates dmbates commented Jun 21, 2024

I think this is a slightly more effective (even more microseconds saved!) way of enhancing the type inference.

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

@dmbates dmbates requested a review from palday June 21, 2024 16:33
@dmbates
Copy link
Collaborator Author

dmbates commented Jun 21, 2024

Shall we do a JuliaFormatter run before merging?

Copy link

codecov bot commented Jun 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.93%. Comparing base (39dd384) to head (598e77d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #773   +/-   ##
=======================================
  Coverage   96.93%   96.93%           
=======================================
  Files          34       34           
  Lines        3356     3356           
=======================================
  Hits         3253     3253           
  Misses        103      103           
Flag Coverage Δ
current 96.87% <100.00%> (ø)
minimum 96.83% <100.00%> (ø)
nightly 96.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday
Copy link
Member

palday commented Jun 22, 2024

@dmbates the format bot hasn't complained, but if you want to run JuliaFormatter manually, please feel free to do so!

@dmbates dmbates merged commit ce5b604 into main Jun 22, 2024
12 checks passed
@dmbates dmbates deleted the db/types2 branch June 22, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants