Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

begin supporting public keyword #776

Merged
merged 8 commits into from
Jul 17, 2024
Merged

begin supporting public keyword #776

merged 8 commits into from
Jul 17, 2024

Conversation

palday
Copy link
Member

@palday palday commented Jul 12, 2024

Thanks for contributing!

Did behavior change? Did you add need features? If so, please update NEWS.md

  • add entry in NEWS.md
  • after opening this PR, add a reference and run docs/NEWS-update.jl to update the cross-references.

Should we release your changes right away? If so, bump the version:

  • I've bumped the version appropriately

Copy link

codecov bot commented Jul 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.99%. Comparing base (a45fc14) to head (015767c).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #776   +/-   ##
=======================================
  Coverage   96.99%   96.99%           
=======================================
  Files          34       34           
  Lines        3360     3360           
=======================================
  Hits         3259     3259           
  Misses        101      101           
Flag Coverage Δ
current 96.93% <ø> (ø)
minimum 96.84% <ø> (-0.06%) ⬇️
nightly 96.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palday palday marked this pull request as ready for review July 17, 2024 15:17
@palday palday requested a review from dmbates July 17, 2024 15:17
Copy link
Collaborator

@dmbates dmbates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea

@palday palday merged commit b551a03 into main Jul 17, 2024
11 of 12 checks passed
@palday palday deleted the pa/public branch July 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants