Fix and test broken quad! and invquad!
#190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
... and 3 files with indirect coverage changes 📢 Thoughts on this report? Let us know!. |
andreasnoack
approved these changes
Oct 16, 2023
|
What is going on on nightly? |
|
I'm not sure, in particular since tests only failed on Ubuntu. I'll rerun them to see if the failures show up persistently. |
|
Seems we were just unlucky. I guess we should try to fix the RNG if these failures appear more often. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PDMats 0.11.26 broke
invquads!due to a bug in the check of the dimensions of the input arguments: JuliaStats/Distributions.jl#1789This issues was not noticed since
quad!andinvquad!were not tested.