Ensure that the output of X_A_Xt etc. is symmetric
#191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The performance improvement in a97533d had an unforeseen side effect: It increases the probability that the output of the tri products (for
PDiagMatmatrices) is numerically not exactly symmetric. This causes downstream issues (e.g., in Distributions: JuliaStats/Distributions.jl#1789 (comment)) in further computations (such ascholesky) that fail/error (more often) if the output is not symmetric.This PR wraps the output of
X_A_Xtetc. in aSymmetricto fix these issues. I also added tests.