⬆️ SecretManagement 1.1.0 Compatibility #55
Conversation
SecretManagement 1.1.0 moves the vault extension into its own runspace and adds a new Unlock-SecretVault mechanism. This adds support for that new operating model.
* Added PSFramework Logging prereq * Added updating an existing entry to Set-Secret and to SecretManagement.KeePass/Tests/SecretManagementVault.Tests.ps1 * Logging added to Unlock-SecretVault Version increase * Removed investigative logging * Update Dependencies
|
@Callidus2000 if you can find out why Write-PSFMessage -Error has different behavior than write-error that causes the trap tests to fail I'd appreciate it, otherwise I'm just going to revert them to write-error for now. |
|
@JustinGrote The PSFramework works with an Opt-In-Exception concept. Because of this |
|
Hi, |
Still failing tests I haven't gotten around to troubleshooting yet. |
There was a problem hiding this comment.
Microsoft.Powershell.SecretManagement 1.1.0 GA has been released, FWIW. (.config/RequiredModules.psd1)
https://devblogs.microsoft.com/powershell/announcing-secretmanagement-1-1-ga/
|
Yeah I'm aware, this is a volunteer project and I only have so much time in the day, if you want to sponsor me to pay to get it done I can dedicate more time to it, or you can help contribute to fix the bugs so that the tests pass :) |
|
Taking a look at it, first encounter with GitHub actions for me.... |
|
Yargh...
If I comment out the windows os everything runs. For me currently a mystery is why the tests fail on windows. I've eliminated all bugs caused by my lazy PSFramework integration (and missing the other pester test files), all tests run on my windows system. |
|
Looks like PSFramework hasn't been added to the Press prerequisite module list so it's not downloading it. |
|
Any hint where to do this? |
.config/RequiredModules.ps1, secretmanagement should be bumped too |
|
Nope, this one I'd already found: @{
'Microsoft.Powershell.SecretManagement' = '1.1.0'
'PowerConfig' = '0.1.3'
'PSFramework' = '1.6.205'
} |
|
@Callidus2000 I'm just saying that's why it's failing in this PR currently. |
|
Hi @JustinGrote, misunderstood you... I want to help to get rid of the errors. In order to do so I created a new fork and fixed everything but the workflow tests under Windows. I do not understand why as (now all) the pester tests work fine my Win10 real system. |
In my previous commit I added PSFramework into the module as one change. Doing so I totally missed that there are more than one pester file. Now all the following tests work under my win10 system:
Register-KeePassSecretVault.Tests.ps1
Get-Secret.Tests.ps1
Remove-Secret.Tests.ps1
Test-SecretVault.Tests.ps1
SecretManagementVault.Tests.ps1
(used Get-ChildItem *.Tests.ps1 -Recurse|ForEach-Object {. $_.FullName} for running all tests)
After a little digging into the GitHub Actions the automatic build&test now work, too. With one exception: the windows-os-runners fail the tests with "missing modules" error messages (The required module 'Microsoft.Powershell.SecretManagement' is not loaded). This work week was too long, cannot find the specific tree in the forest. Therefor I commented the windows entries in press.yml out to make the workflow work without it.
-Sascha aka callidus2000
* Update press.yml
Added PSFramework
* Added PSFramework
* Corrected Spelling Error "PSFramwork" (missing 'e')
* Fixed pester tests errors caused by converting to Write-PSFMessage
* -Removed os:
ubuntu-16.04 (as deprecated)
macos-latest (as identical with explicit version)
windows-latest (as identical with explicit version)
ubuntu-latest (as identical with explicit version)
* Removed Windows os
* Update press.yml
|
@Callidus2000 what looks like is happening is the pester tests are run in a separate standalone job for some tests, and secretmanagement is not getting loaded into that job. It's looking pretty good otherwise, I imagine I can fix that pretty quick tonight. Thanks for your hard work on this. |
|
@Callidus2000 it's the Windows Powershell (5.1) tests that are failing |
|
There appears to be a recursion issue with running the WInPS tests in a Windows Powershell Job, doesnt happen when run as a main process though. I'll see if I can workaround it for now and fully fix later. |
|
I'm pretty sure the problem is the PSModulePath isn't carrying into the 5.1 job |
|
The problem is a transient stacktrace problem when doing winPS tests. I've disabled the tests with a warning for now since they all pass locally and will merge. |
|
@Callidus2000 thanks for your patience on this. |
|
@JustinGrote No problem, I fully understand the problem of missing free times for personal projects. I'm glad that the problems had some base within the underlying/used eco system ;-) |
SecretManagement 1.1.0 moves the vault extension into its own runspace and adds a new Unlock-SecretVault mechanism. This adds support for that new operating model.