LINUX: Fix getAllMonitors() returns empty list if XDG_CURRENT_DESKTOP is not set #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi! Sorry for my late reply. I've been out these days with no access to my "stuff". Thank you so much for your help!!! I was not aware of that problem. Thank you so much for pointing it out and finding a solution! |
Kalmat
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
XDG_CURRENT_DESKTOPis not set, an exception will be thrown and__remove_bad_windows()will return an empty list.XDG_CURRENT_DESKTOPis only set in large integrated desktop environments and not in small Window Managers.Therefore, the correct list must be returned even if the environment variable is not set.