Initial tests to verify a new connection #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Jeconias
commented
Oct 19, 2020
•
Jeconias
commented
LalitNM
requested changes
Oct 19, 2020
Jeconias
force-pushed
the
initial-tests
branch
from
3172b4a
to
d79cdc4
Compare
|
@LalitNM, I defined the version mocha in 6.2.3 to enable the use with node 6.9.4. |
LalitNM
reviewed
Oct 19, 2020
|
@Jeconias these many changes are enough for this pull request. I will look into the versions of all dependencies and will rectify the errors. Then I will finally merge this pull. Work from your end is done for this pull request. Meanwhile can you list some more tests in this. This will help in opening more issue on tests. |
LalitNM
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.