Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a hall of fame page for sys admins as well. #28 #36

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Payalsahb20220
Copy link

Hello sir!
I create a hall of fame page .
please look upon it.

@LalitNM
Copy link
Member

LalitNM commented Feb 15, 2022

Could you please add a screenshot for such visual changes?

@Payalsahb20220
Copy link
Author

Payalsahb20220 commented Feb 15, 2022 via email

@LalitNM
Copy link
Member

LalitNM commented Feb 15, 2022

I didn't mean to add screenshot in the repository as a commit. I meant to add a screenshot here in comments section so that anyone can see what changes you have made without cloning your repository.

Also, please remove dummy images from the page.

@Payalsahb20220
Copy link
Author

Hello sir!
I added screenshots folder .
now you see , is it looks good or not?

@LalitNM
Copy link
Member

LalitNM commented Feb 15, 2022

Following changes need to be incorporated:

  1. SnTC logo should be in middle, its position should not change.
  2. On system admins page, the text system admins should be highlighted in top bar.
  3. Dummy images of some professor at IIT Mandi should be replaced with current and past system admins. @yash-bansod can you please help us to collect this data?

Other changes look good. Nice job Payal 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants