Speed up bb2fline.py

bb2fline.py

@@ -4,11 +4,18 @@
 from collections import defaultdict
 from subprocess import PIPE
 
+def batch_addr2line(addr2line, binary, addresses):
+    """Batch process addresses to improve efficiency."""
+    cmd = [addr2line, '-e', binary, '-f']
+    result = subprocess.run(cmd, input='\n'.join(addresses), stdout=PIPE, stderr=PIPE, text=True)
+    return result.stdout.strip().splitlines()
+
 def bb_to_fline(bb_csv, binary, addr2line):
     assert bb_csv.endswith('bb.csv'), 'not normalized name'
     f_csv = bb_csv[:-6] + 'f.csv'
     line_csv = bb_csv[:-6] + 'line.csv'
-    with open(bb_csv, 'r') as bb_csv_file, open(f_csv, 'w') as f_csv_file, open(line_csv, 'w') as line_csv_file:
+
+    with open(bb_csv, 'r') as bb_csv_file:
         bb_reader = csv.DictReader(bb_csv_file)
         fieldnames = bb_reader.fieldnames.copy()
         for name in ['entry', 'execution', 'exit']:
@@ -19,22 +26,29 @@ def bb_to_fline(bb_csv, binary, addr2line):
         f_fieldnames.insert(0, 'name')
         line_fieldnames.insert(0, 'source_line')
 
-        fs_metrics = defaultdict(lambda:defaultdict(int))
-        lines_metrics = defaultdict(lambda:defaultdict(int))
+        fs_metrics = defaultdict(lambda: defaultdict(int))
+        lines_metrics = defaultdict(lambda: defaultdict(int))
 
+        # Collect addresses for batch processing
+        addresses = []
+        bb_entries = []
         for bb in bb_reader:
             entry = bb['entry']
-            addr2line_cmd = f'{addr2line} -e {binary} -a {entry} -f'
-            fline = subprocess.run(addr2line_cmd.split(), stdout=PIPE, stderr=PIPE, check=True)
+            addresses.append(entry)
+            bb_entries.append(bb)
+
+        # Batch process addresses with addr2line
+        addr2line_output = batch_addr2line(addr2line, binary, addresses)
+        addr2line_lines = iter(addr2line_output)
+
+        for bb in bb_entries:
+            entry = bb['entry']
             # Assume output looks like:
             #
-            # 0x00000000004011a4
             # main
             # a.c:11
-            fline = fline.stdout.decode('utf-8').strip()
-            lines = fline.splitlines()
-            name = lines[1].strip()
-            source_line = lines[2].strip()
+            name = next(addr2line_lines).strip()
+            source_line = next(addr2line_lines).strip()
             f_metrics = fs_metrics[name]
             line_metrics = lines_metrics[source_line]
             f_metrics['name'] = name
@@ -46,6 +60,8 @@ def bb_to_fline(bb_csv, binary, addr2line):
                 if key in line_fieldnames:
                     line_metrics[key] += int(val or 0)
 
+    # Write output files
+    with open(f_csv, 'w') as f_csv_file, open(line_csv, 'w') as line_csv_file:
         f_writer = csv.DictWriter(f_csv_file, fieldnames=f_fieldnames)
         f_writer.writeheader()
         for key, val in fs_metrics.items():
@@ -57,15 +73,11 @@ def bb_to_fline(bb_csv, binary, addr2line):
             line_writer.writerow(val)
 
 
-
 if __name__ == '__main__':
     parser = argparse.ArgumentParser(
         description='Get function & line profiling info from basic block info (CSV format), where entry, execution, exit are required')
     parser.add_argument('bb_csv', help='input bb CSV file')
     parser.add_argument('binary', help='profiled binary')
     parser.add_argument('--addr2line', default='addr2line', help='path of addr2line (this is needed if dwarf format of binary is not supported by system addr2line)')
     args = parser.parse_args()
-    bb_csv = args.bb_csv
-    binary = args.binary
-    addr2line = args.addr2line
-    bb_to_fline(bb_csv, binary, addr2line)
+    bb_to_fline(args.bb_csv, args.binary, args.addr2line)