This repository has been archived by the owner on Jul 2, 2021. It is now read-only.
snackbar duration #133
Closed
snackbar duration #133
+18
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
i guess there is a shorter or a better code :)
Serchinastico
suggested changes
Mar 18, 2017
There was a problem hiding this comment.
Fix the checkstyle and the small comments and this PR can be merged.
Thank you very much for your contribution @bluemix !
| @@ -37,6 +37,7 @@ | |||
| private final String buttonText; | |||
| private final View.OnClickListener onButtonClickListener; | |||
| private final Snackbar.Callback snackbarCallback; | |||
| private int duration = 5_000; | |||
There was a problem hiding this comment.
No need to give it a default value if it already has one in the builder
| @@ -76,16 +80,26 @@ private SnackbarOnDeniedPermissionListener(ViewGroup rootView, String text, Stri | |||
| private String buttonText; | |||
| private View.OnClickListener onClickListener; | |||
| private Snackbar.Callback snackbarCallback; | |||
| private int duration = 5_000; | |||
There was a problem hiding this comment.
The previous default value was Snackbar.LENGTH_LONG
| public static Builder with(ViewGroup rootView, String text) { | ||
| return new Builder(rootView, text); | ||
| } | ||
|
|
||
| public static Builder | ||
| with(ViewGroup rootView, String text, int duration) { |
There was a problem hiding this comment.
Being duration an optional parameter, I'd create a new non-static method withDuration instead
|
Besides, there is a very similar implementation called |
Merged
|
I'm merging this PR in #141 and releasing a new version |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i guess there is a shorter or a better code :)