Updated libraries #208
Updated libraries #208
Conversation
rid-x
commented
Jun 12, 2018
rid-x
commented
- Updated gradle plugin version to 3.1.3
- Updated compileSdkVersion, buildToolsVersion, targetSdkVersion to 27
- Updated support lib version to 27.1.1
- Changed deprecated dependency api to new
- Updated gradle plugin version to 3.1.3 - Updated compileSdkVersion, buildToolsVersion, targetSdkVersion to 27 - Updated support lib version to 27.1.1 - Changed deprecated dependency api to new
There was a problem hiding this comment.
Let's review my comment about the min SDK version supported and we are ready to merge 😃 @Serchinastico we should publish a new release after merging this branch.
|
|
||
| defaultConfig { | ||
| minSdkVersion 10 | ||
| targetSdkVersion 25 | ||
| minSdkVersion 14 |
There was a problem hiding this comment.
Hi @rid-hrant I'm taking a look at this PR and I was wondering why you've increased the minSdkVersion. This change is huge right now. As we can review in these pages, the rest of the updates are correct and we are using the latest version released:
https://developer.android.com/studio/releases/gradle-plugin
https://developer.android.com/studio/releases/build-tools
https://developer.android.com/topic/libraries/support-library/revisions
But we should review this minSdkVersion carefully right @Serchinastico? I'm ok if we update the min SDK but we should keep it in mind and at least add this information to the release notes.
There was a problem hiding this comment.
Hi my friend 😄 . I try to use dexter in my updated gradle version poroject, but it has conflict with support libs, so I decided to contribute and update libs and gradle version.
Min sdk version 10 has conflict with new support libs 27 version, so I had to update version to 14, 14 is android stidio's recomendid version.
Thanks for answering.
Sorry for bad english
|
I forgot to thank you @rid-hrant xD Thanks you so much for your contribution 😃 |
|
Ups I didn't read your comment @rid-hrant
I'm ok updating the min SD version. Let's see what the rest of the team says about this. |
|
OK @pedrovgs I'll waiting reaction of the team. |
|
I'll be reviewing it next thursday 👍 |
|
@Serchinastico thank you to! 😄 |
