Fixed layout and non responsive buttons in the login and create account flow #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed login button responsiveness and layout on android - Fixed error in logging analytics during create account flow.
Alert.alert cancels Modal dismiss even so we end up with a non responsive Modal confirmation dialog. This is explained here: facebook/react-native#10471 I used the workaround suggested in the thread by adding a short timeout to Alert.alert Todo: eventually we should better handle this by launching the error dialog from the teacher screen instead of redux, but this workaround is good for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create Account button was not responsive on Android due to zIndex mismatch. Fixed the Login dialog flow to fix the problem as well as make the flow flex based.
Fixed an issue in iOS in the TeacherWelcomeScreen where there are cases where the confirm account dialog becomes non responsive if an error dialog shows up on top of it. This is due to this issue: facebook/react-native#10471
I also modified the logic of the teacher welcome page so that when user dismisses the account confirmation dialog, the button will now say "confirm account" and will only go through the confirmation flow and not attempt to re-create the account.
Please test these screens as much as you can since there is quite a bit of logic and we need a lot of validation to flush out all bugs.
Thanks,