Skip to content

Commit

Permalink
[🔥AUDIT🔥] Add white background for social preview image (#122)
Browse files Browse the repository at this point in the history
🖍 _This is an audit!_ 🖍

## Summary:
This has the same dark mode problem (if your Twitter client, say, is in
dark mode), but we can't be so fancy with CSS, I uess.  So I just
switched to a white background, which looks fine in context.  The actual
source of truth for the social preview image is in the github settings
page, but I checked in the image for reference.

## Test plan:
looks fine in the compose window on Facebook:
![Screenshot 2021-09-30 at 09-34-49 Facebook](https://user-images.githubusercontent.com/111238/135495585-39208971-04d8-4c56-9df1-61970504858b.png)

Author: benjaminjkraft

Auditors: dnerdy

Required Reviewers: 

Approved By: 

Checks: ⌛ Test (1.17), ⌛ Test (1.16), ⌛ Test (1.15), ⌛ Test (1.14), ✅ Lint, ⌛ Test (1.17), ✅ Test (1.16), ✅ Test (1.15), ✅ Test (1.14), ✅ Lint

Pull Request URL: #122
  • Loading branch information
benjaminjkraft committed Sep 30, 2021
1 parent c6d087c commit 9ef7636
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
8 changes: 7 additions & 1 deletion docs/images/README.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# genqlient logo

`genqlient-orig.svg` is the original logo. To create `genqlient.svg`, I:
`genqlient-orig.svg` is the original logo, in editable SVG. To create `genqlient.svg`, I:
- converted all text to paths
- added media queries to make the paths white if the user is in dark mode (see issue #17)

For the social preview image (in GitHub settings), I ran:
```sh
convert -resize 2560x1280 -density 600 -gravity center \
-extent 2560x1280 docs/images/genqlient.{svg,png}
```
Binary file added docs/images/genqlient.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 9ef7636

Please sign in to comment.