Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bp: Improve max sync object message #8470

Merged
merged 1 commit into from
Aug 28, 2024
Merged

bp: Improve max sync object message #8470

merged 1 commit into from
Aug 28, 2024

Conversation

spencer-lunarg
Copy link
Contributor

for #8469

now prints

Validation Performance Warning: [ BestPractices-SyncObjects-HighNumberOfFences ] | MessageID = 0xa9f4ff68 | vkCreateFence(): [AMD] [NVIDIA] High number of VkFence objects created. 4 created, but recommanded max is 3. Minimize the amount of CPU-GPU synchronization that is used. Semaphores and fences have overhead. Each fence has a CPU and GPU cost with it.

@spencer-lunarg spencer-lunarg requested a review from a team as a code owner August 28, 2024 16:03
@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build queued with queue ID 245137.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17338 running.

@ci-tester-lunarg
Copy link
Collaborator

CI Vulkan-ValidationLayers build # 17338 passed.

@spencer-lunarg spencer-lunarg merged commit d9ae959 into KhronosGroup:main Aug 28, 2024
21 checks passed
@spencer-lunarg spencer-lunarg deleted the spencer-lunarg-bp-sync branch August 28, 2024 17:00
@filnet
Copy link
Contributor

filnet commented Aug 28, 2024

There are similar limits checked for semaphores, barriers, etc.

@spencer-lunarg spencer-lunarg mentioned this pull request Aug 29, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filnet filnet filnet left review comments

@artem-lunarg artem-lunarg artem-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@spencer-lunarg @ci-tester-lunarg @filnet @artem-lunarg