Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename VirtualCity files to match asset name #89

Closed
wants to merge 1 commit into from

Conversation

javagl
Copy link
Contributor

@javagl javagl commented Dec 26, 2023

The folder name had been changed from VC to VirtualCity. The individual files still had been called VC.gltf/VC.glb (as pointed out in #71 (comment) ).

They are renamed here to VirtualCity as well

@cx20
Copy link

cx20 commented Dec 27, 2023

Perhaps it would be better to modify model-index.json as well.

"glTF": "VC.gltf",
"glTF-Binary": "VC.glb",
"glTF-Draco": "VC.gltf",
"glTF-Embedded": "VC.gltf"

@javagl
Copy link
Contributor Author

javagl commented Dec 27, 2023

@cx20 Some aspects still have to be sorted out here. In the future, the model index should be updated automatically, as of #54 (yes, that's somehow still on my plate as well, and I should give it higher priority).

(I'm curious whether you'd use the model-index.json for gltf-test as well - right now, you're maintaining the README manually, is that correct? If you have any thoughts or ideas for what the CI should or shouldn't do, you can mention them in #54 . It's important to set things up in a way that allows the results to be easily consumed by projects like yours)

@DRx3D
Copy link
Contributor

DRx3D commented Dec 27, 2023

The name change is also done in (not yet merged) PR #87. Since that brings in a several other models and there is a change to the README to include model extensions, I think it would be better to close this without merging. I am just about to merger #87.

@DRx3D
Copy link
Contributor

DRx3D commented Dec 27, 2023

Had a change of mine. #87 will remain open until 4 Jan 2024 to allow people a chance to comment due to the holidays.

@javagl javagl closed this Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants