feat: add only issues option (opposite of ignoredIssues) #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
lexaknyazev
reviewed
May 2, 2023
|
Any estimate on when this might be released? |
|
I have the same issue when will this be released? |
|
@lexaknyazev is there any chance that this will be merged soon? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it possible to provide a list of the only errors we want to validate (opposite of ignoredIssues). In my case I only want to check for 'ACCESSOR_INVALID_FLOAT', so this is easier than providing every other error using ignoredIssues.
Why? Our users often download broken models from the internet, and yet most 3d model viewers are sensible to some of the errors and can still load them. We also run them through Draco compression, and some of the errors end up not having a visible effect. But because of this issue with NaN in Draco (google/draco#998), we want to avoid the bus error (and thus the hanging). Ideally, it is something that will be handled by Draco itself in the future; But until then, the glTF-Validator is the best tool to check and avoid such specific error.