Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web: Support resources in dropped directories #236

Merged
merged 1 commit into from
Sep 5, 2024

Conversation

lexaknyazev
Copy link
Member

Fixes #232.

Notes:

  • Directory access is not available when the Validator is opened from a local disk, i.e., with the file:// URI. This is a Web platform limitation.
  • Directories cannot be selected from the system dialog opened by the "Select" link. This is also a web platform limitation.
  • Dropping a single directory with a glTF (or GLB) asset inside is intentionally not supported.

/cc @emackey @javagl @echadwick-artist

@lexaknyazev lexaknyazev merged commit ee84629 into KhronosGroup:main Sep 5, 2024
2 checks passed
@lexaknyazev lexaknyazev deleted the web-dirs branch September 5, 2024 11:08
@javagl
Copy link

javagl commented Sep 5, 2024

I'll have to read more in the linked issues and code changes, but maybe you can quickly confirm: With this change, it will be possible to drag-and-drop, for example, ...

  • an example.gltf that refers to ./images/image.png
  • together with that images subdirectory

and it will resolve that image as part of (or "in the context of") the dropped resources.

Is that correct?
(If so, then this does also resolve #208 ...)

@lexaknyazev
Copy link
Member Author

This is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Web version does not support external resources in subfolders
2 participants