Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the extension GL_EXT_spirv_intrinsics #2625

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Implement the extension GL_EXT_spirv_intrinsics #2625

merged 1 commit into from
Jun 16, 2021

Conversation

amdrexu
Copy link
Contributor

@amdrexu amdrexu commented Apr 25, 2021

  • Add support of SPIR-V execution mode qualifiers.
  • Add support of SPIR-V storage class qualifier.
  • Add support of SPIR-V decorate qualifiers.
  • Add support of SPIR-V type specifier.
  • Add support of SPIR-V intruction qualifiers.
  • Add support of spirv_by_reference/spirv_literal parameter qualifier.
  • Add shader stage macros introduced by this extension.

@amdrexu
Copy link
Contributor Author

amdrexu commented Apr 25, 2021

This change is to implement the extension KhronosGroup/GLSL#157

@amdrexu amdrexu force-pushed the feature branch 3 times, most recently from 051c9f3 to d778218 Compare April 27, 2021 00:41
@greg-lunarg greg-lunarg self-requested a review April 27, 2021 16:38
@greg-lunarg
Copy link
Contributor

Please let me know when you are done and ready for review.

@greg-lunarg greg-lunarg added kokoro:run Trigger Google bot runs and removed kokoro:run Trigger Google bot runs labels Apr 27, 2021
@kokoro-team kokoro-team removed kokoro:run Trigger Google bot runs labels Apr 27, 2021
@greg-lunarg
Copy link
Contributor

greg-lunarg commented Apr 27, 2021 •
edited
Loading

Re the CI-ubuntu-clang-gn failure, make sure you add any new non-test source files to BUILD.gn.

@amdrexu
Copy link
Contributor Author

amdrexu commented Apr 28, 2021

Re the CI-ubuntu-clang-gn failure, make sure you add any new non-test source files to BUILD.gn.

Thank you. I did forget to do this.

@greg-lunarg greg-lunarg added kokoro:run Trigger Google bot runs and removed kokoro:run Trigger Google bot runs labels Apr 28, 2021
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label May 3, 2021
@amdrexu
Copy link
Contributor Author

amdrexu commented May 5, 2021

@greg-lunarg I couldn't load the webpage to check what was wrong in the fail job. Only this job CI-ubuntu-clang-gn fails. Could you help to check it and tell me the details. I think I have follow your previous suggestions and have no idea about what is still missing.

@greg-lunarg
Copy link
Contributor

Yeah. For reason that link is often broken. I will dig into it...

@greg-lunarg
Copy link
Contributor

Please see this link:

https://source.cloud.google.com/results/invocations/13c1a60e-435d-4a2c-a37d-56d471ba4411/targets

@amdrexu
Copy link
Contributor Author

amdrexu commented May 6, 2021

@greg-lunarg I found the root cause and fix it now. Thanks for providing this info to me.

@greg-lunarg greg-lunarg added the kokoro:run Trigger Google bot runs label May 6, 2021
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label May 6, 2021
@greg-lunarg
Copy link
Contributor

Another compilation problem:

https://source.cloud.google.com/results/invocations/3210e945-7f84-4fd3-aedd-a0fa48973269/targets

@amdrexu
Copy link
Contributor Author

amdrexu commented May 7, 2021

I fix it now. This change is somewhat large. If there are issues, I will continue to fix them. Once again, thanks for your patience and help.

@greg-lunarg greg-lunarg added the kokoro:run Trigger Google bot runs label May 7, 2021
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label May 7, 2021
@greg-lunarg
Copy link
Contributor

I have one other larger task to finish and then will get to this. Sorry for the delay!

@amdrexu
Implement the extension GL_EXT_spirv_intrinsics
65a7fb7 
- Add support of SPIR-V execution mode qualifiers.
- Add support of SPIR-V storage class qualifier.
- Add support of SPIR-V decorate qualifiers.
- Add support of SPIR-V type specifier.
- Add support of SPIR-V intruction qualifiers.
- Add support of spirv_by_reference/spirv_literal parameter qualifier.
- Add shader stage macros introduced by this extension.
@amdrexu
Copy link
Contributor Author

amdrexu commented Jun 9, 2021

@greg-lunarg I rebase this PR. Thanks.

@greg-lunarg greg-lunarg added the kokoro:run Trigger Google bot runs label Jun 9, 2021
@kokoro-team kokoro-team removed the kokoro:run Trigger Google bot runs label Jun 9, 2021
greg-lunarg
greg-lunarg approved these changes Jun 16, 2021
View reviewed changes
Copy link
Contributor

@greg-lunarg greg-lunarg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the work!

@greg-lunarg
Copy link
Contributor

And sorry about making you rebase!

@greg-lunarg greg-lunarg merged commit 71612a7 into KhronosGroup:master Jun 16, 2021
@Tobski Tobski mentioned this pull request Jul 1, 2021
Open
@jaebaek jaebaek mentioned this pull request Aug 30, 2021
Closed
@greg-lunarg greg-lunarg mentioned this pull request Oct 18, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greg-lunarg greg-lunarg greg-lunarg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amdrexu @greg-lunarg @kokoro-team