-
Notifications
You must be signed in to change notification settings - Fork 827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GL_EXT_spirv_intrinsics port of GL_EXT_shader_realtime_clock #2749
Conversation
4c717cd
to
d2ae92d
Compare
Re testing failures, it looks like you will need to inform the other builds of the new files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some general comments:
- I am generally fine with moving ahead with this new framework for extension intrinsic functions.
- I would like to see the extension-specific headers generated into the "build" directory rather than into the "source" tree.
- If I am understanding this PR correctly, the header file glslang/ExtensionHeaders/GL_EXT_shader_realtime_clock.h is a generated file and should not be part of the source controlled repo, right?
I re-worked this to take the header files from glslang\ExtensionHeaders and put them in build\include\glslang\glsl_intrinsic_header.h |
bbf7d5e
to
802731d
Compare
I think you are going to have to update the bazel and gn builds, which will likely mean changes to BUILD.bazel and BUILD.gn in the root directory, and possibly other supporting scripts or files. |
I am still seeing that you are attempting to add glslang/ExtensionHeaders/GL_EXT_shader_realtime_clock.h to the repo (see my comment above) which I believe is incorrect. This is the reason for the license failure above. I think if you fix this as I suggest above the license failure will go away. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the bazel and gn builds and fix GL_EXT_shader_realtime_clock.glsl as I have requested in the comments section.
glslang/ExtensionHeaders/GL_EXT_shader_realtime_clock.h should be removed from my latest commit (802731d) |
Add mechanism to use GL_EXT_spirv_intrinsics headers in glslang. Ported GL_EXT_shader_realtime_clock as an example.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Latest code LGTM
Heads up: this PR was partially reverted by #2817, specifically the port of GL_EXT_shader_realtime_clock. This was due to regressions caused for users of the glslang library interface. We were building for the SDK and did not have time to fix this, hence the revert. Please address this problem and re-submit. |
Add mechanism to use GL_EXT_spirv_intrinsics headers in glslang.
Ported GL_EXT_shader_realtime_clock as an example.