-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
makefile: ignore errors during clean #36
makefile: ignore errors during clean #36
Conversation
maybe this is too aggressive, and -f should be removed in case the failure is legitimate (e.g. no write access to the file(s)?), what do y'all think? |
I suggest you remove Perfectly happy with the As we assume we are running in the top-level directory (which is reasonable) remove the Do we need the $(PWD) in the firmware rules? If not remove those too. Unrelated... does the .PHONY target with dependencies do anything with those dependencies? If not I suggest we remove them. I will be adding a install target for my update script. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update commit message to remove the "the single dash" part. I had a few other suggestions (above) that I suggest we just squeeze in here.
Seems like it is, else the build fails because it can't find the board (presumably because config wasn't passed into the container?) output from failed `make`
though it works if I replace
honestly I'd probably just keep
I think the rest of this feedback is at risk of causing feature creep for a patch that was simply meant to cause make to not fail when rm-ing non-existant files 😄 |
bd4c070
to
9f87850
Compare
The file(s) being removed may not exist, but make shouldn't fail because of it: $ make clean rm ./firmware/*.uf2 rm: cannot remove './firmware/*.uf2': No such file or directory make: *** [Makefile:10: clean] Error 1 $ echo $? 2 this also removes leading ./ from path in clean, and assumes that `make clean` is being run from the top level repo dir
9f87850
to
78df0ff
Compare
Just rename the pull request then. We are talking about a few lines in the Makefile. Or if you don't want to do it, say so, and I will submit a PR for it (I would just like it done). |
It's all yours
On October 24, 2022 10:33:45 AM PDT, Allan Wind ***@***.***> wrote:
***@***.*** requested changes on this pull request.
…
Update commit message to remove the "the single dash" part. I had a few other suggestions that I suggest we just squeeze in here.
--
Reply to this email directly or view it on GitHub:
#36 (review)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
I'd definitely prefer the other changes being proposed to be in a separate PR |
So let's get those changes in and I will file another PR when this gets merged. |
3d661ed
to
78df0ff
Compare
…an-no-fail makefile: ignore errors during clean
…an-no-fail makefile: ignore errors during clean
The file(s) being removed may not exist, but make shouldn't fail because of it:
-f silences any output from rm even though the single dash tells make to ignore the failure, which just creates noise.