Skip to content

Commit

Permalink
To use custom dev_server.host configured in webpacker.yml (#593)
Browse files Browse the repository at this point in the history
we need to explicitly configure webpack-dev-server with hostname port
ref webpack/webpack-dev-server#882 (comment)
  • Loading branch information
KingTiger001 committed Aug 6, 2017
1 parent 5f907e1 commit e09f856
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/install/bin/webpack-dev-server.tt
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ if Gem.win_platform?
WEBPACK_CONFIG, "--host", LISTEN_IP_ADDR, "--port", PORT.to_s] + ARGV
else
cmdline = ["yarn", "run", "webpack-dev-server", "--", "--progress", "--color", "--config",
WEBPACK_CONFIG, "--host", LISTEN_IP_ADDR, "--port", PORT.to_s] + ARGV
WEBPACK_CONFIG, "--host", LISTEN_IP_ADDR, "--public", "#{HOSTNAME}:#{PORT}", "--port", PORT.to_s] + ARGV
end

Dir.chdir(APP_PATH) do
Expand Down

0 comments on commit e09f856

Please sign in to comment.