Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run functional tests on freshly built container #3367

Merged
merged 3 commits into from
Jan 26, 2024
Merged

Conversation

leplatrem
Copy link
Contributor

This will make sure we don't break the docker build and that published images always get consistently tested.

@leplatrem
Copy link
Contributor Author

Screenshot 2024-01-25 at 16 53 57

🎉

@leplatrem leplatrem marked this pull request as ready for review January 25, 2024 15:54
Comment on lines +159 to +168
- name: Compute cache key
# Create hash of hashes of checked in files not in Dockerignore
run: echo "CACHE_KEY=$(git ls-tree --full-tree -r HEAD | grep -v -f .dockerignore | awk '{print $3}' | git hash-object --stdin)" >> $GITHUB_ENV

- uses: actions/cache@v3
with:
path: ${{ env.DOCKER_CACHE}}
key: docker-build-${{ hashFiles('Dockerfile') }}-${{ env.CACHE_KEY }}
restore-keys: |
docker-build-${{ hashFiles('Dockerfile') }}-${{ env.CACHE_KEY }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to the day that there's an easier way to do this ...

@leplatrem leplatrem merged commit 425b97d into main Jan 26, 2024
15 checks passed
@leplatrem leplatrem deleted the run-functional-docker branch January 26, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants