MK-85 Change the syntax following depreciation warnings #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vonhraban
changed the title
macieklewkowicz
requested changes
Sep 28, 2023
There was a problem hiding this comment.
It looks like Kustomize dropping support for multiple patches in single file was a regression and is now fixed: kubernetes-sigs/kustomize#5194
Multiple patches were grouped into files by responsibility. Splitting them into single patch per file will make it more difficult to track what is being patched and why.
|
Converting to draft; it seems that it will be fixed in the next version of kustomize |
auto-merge was automatically disabled
October 9, 2023 12:30
Pull request was converted to draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes syntax of Kustomize files, as well as splits patches into several files since it is not supported anymore to have multiple patches in one file