Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update fast_tsne.m #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update fast_tsne.m #104

wants to merge 1 commit into from

Conversation

fancy23
Copy link

@fancy23 fancy23 commented May 28, 2020

line 256: for cmd to run fit-tsne, it should be FItSNE.exe rather than fast_tsne to be used for calculation

line 256: for cmd to run fit-tsne, it should be  FItSNE.exe rather than fast_tsne to be used for calculation
@linqiaozhi
Copy link
Member

Thanks for the PR--and so sorry for the long delay.

That's only for Windows though. We should have separate call-lines for Windows and non-Windows (i.e. OS X and Linux).

@sg-s
Copy link
Contributor

sg-s commented Jun 2, 2021

This change would world only on Windows as stated. I don't have a windows computer, but does the binary have a .exe at the end?

@JunweiLiu0208
Copy link

This change would world only on Windows as stated. I don't have a windows computer, but does the binary have a .exe at the end?

You can check your binary name in the directory of fit-tsne.

@sg-s
Copy link
Contributor

sg-s commented Jun 3, 2021

Yes, but I think the point is that your change may make it work on windows, but it breaks it on all other platforms. the solution is to have a check for the platform, and call the .exe on windows only

@sg-s sg-s mentioned this pull request Jun 3, 2021
@sg-s
Copy link
Contributor

sg-s commented Jun 3, 2021

@JunweiLiu0208 I believe #118 should fix your issue. can you test this if you have a windows computer?

@JunweiLiu0208
Copy link

@JunweiLiu0208 I believe #118 should fix your issue. can you test this if you have a windows computer?
Thanks for the contribution.
In windows PC, you should replace the 'fast_tsne.exe' with the 'FItSNE.exe' as the following code.
And I have tested that, it works well!

if ispc
cmd = sprintf('%s %s data.dat result.dat %d',fullfile(tsne_path,'/FItSNE.exe'), version_number, p.nthreads);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants