Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add ctx test handlers, fix hanging channel, fix typo #174

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

winslowdibona
Copy link
Contributor

@winslowdibona winslowdibona commented Feb 13, 2024

This PR attempts to address several issues:

  1. Adds support for kong.ctx.shared.get and kong.ctx.shared.set in the test module
  2. Fixes a typo finnished -> finished
  3. Includes changes introduced by @jakeslee in PR 170 to fix issue with hanging channel in kong.response.exit

@CLAassistant
Copy link

CLAassistant commented Feb 13, 2024

CLA assistant check
All committers have signed the CLA.

@winslowdibona
Copy link
Contributor Author

@jakeslee I've included your changes I saw on PR 170 in mine as I was facing the same issue when testing locally.

@winslowdibona
Copy link
Contributor Author

winslowdibona commented Feb 13, 2024

@fffonion @gszr Who should contributors reach out to when seeking reviews/approval on pull requests? I ask you all
because I see your comments/commits on recent PRs

@gszr gszr merged commit ca4b404 into Kong:master Feb 21, 2024
2 checks passed
@gszr
Copy link
Member

gszr commented Feb 21, 2024

@winslowdibona - Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants