Feat/pbserver #59
Merged
Feat/pbserver #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javierguerragiraldez
force-pushed
the
feat/pbserver
branch
8 times, most recently
from
299409c
to
11a33f3
Compare
javierguerragiraldez
force-pushed
the
feat/pbserver
branch
from
5ae057d
to
2725b3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the
net/rpc/ MsgPack protocol with a simple streaming Protobuf.Pros: much simpler code (no "callback as return StepData" with goroutine+channel-mediated procedure inversion), static-typing
Cons: more explicit copying of complex structs, not compatible with pluginserver (embedded server only)
should be tagged as
v0.7.0-beta1after merging. Don't remove the-betabefore Kong 2.4 GA. Maybe we have to wait to EE 2.4 because we don't want anybody to use this by mistake before all "official latest" Kong images support this protocol