-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove @ExperimentalCoroutinesApi from CancellableContinuation.resume(...) #4088
Comments
We've been sitting on that for a while for quite a specific reason: its signature should've been There was an extended attempt (#3093) to change that and also receive a Taking into account it's experimental for so long if we are going to change the signature and deprecate it, this version is going to stay basically forever. If you have any opinions on the current or potential API shape -- don't hesitate to tell us! |
Thanks for the explanation. I hadn’t expected covariance! |
…back Fixes some concerns in #4088
…back Fixes some concerns in #4088
…back Fixes some concerns in #4088
I’d like to use this overload of
CancellableContinuation.resume()
in OkHttp’s coroutines extension.Unfortunately, this functino is experimental. There’s no stable alternative that combines continuations with safe resource management. I’m going to annotate our own API with
@ExperimentalCoroutinesApi
to pass the responsibility to our callers.I’d like for you to consider removing the experimental annotation from this function. It hasn’t changed since 2020. It solves an important very nicely!
The text was updated successfully, but these errors were encountered: