-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate and document order between cancellation handlers and continuation resume #415
Labels
Comments
qwwdfsad
added a commit
that referenced
this issue
Jul 3, 2018
1) Invoke handlers before dispatching in CancellableContinuation to make behaviour timing-independent and Unconfined doesn't produce unexpected results 2) Invoke onCancellation -> handlers -> onCompletion in Job to make behaviour timing-independent Fixes #415
So this is fixed but not released yet? |
Yes |
Can this please be released soon? About 0.7% of my sessions are crashing with this exception. |
Presumably it will be released next week |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reproducer from #407 will fail with exception in coroutines machinery
Behaviour will be different for
Unconfined
andcoroutineContext
asctx
.It's because we do the following:
We have data-race with small window between dispatched continuation and handlers invocation. Same race is 100% reproducible with Unconfined.
The text was updated successfully, but these errors were encountered: