Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop building and publishing compatibility MPP metadata variant #3809

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

ilya-g
Copy link
Member

@ilya-g ilya-g commented Jul 17, 2023

Please review the changes in the published artifacts in kotlinx-coroutines-core and kotlinx-coroutines-test:

  • the main artifact is now a common klib (with .jar extension) instead of legacy metadata jar,
  • no artifact is published under -all classifier, which was previously a common klib.

Also remove flag `kotlin.mpp.enableGranularSourceSetsMetadata` that has no effect anymore
@ilya-g ilya-g requested a review from qwwdfsad July 17, 2023 20:22
@@ -278,7 +274,7 @@ configure(subprojects.findAll { !unpublished.contains(it.name) }) {

List<String> jarTasks
if (isMultiplatform(it)) {
jarTasks = ["jvmJar", "metadataJar"]
jarTasks = ["jvmJar"]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure whether we need this version info in allMetadataJar instead or not.

Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I've checked the contents locally, will publish dev version to space and poke it a bit, will merge shortly after

@qwwdfsad qwwdfsad merged commit 5c4a252 into develop Jul 18, 2023
@qwwdfsad qwwdfsad deleted the ig/no-legacy-mpp branch July 18, 2023 16:31
@ilya-g
Copy link
Member Author

ilya-g commented Jul 19, 2023

I will need this commit also in kotlin-community/dev branch. Would it be ok to just cherry-pick it there?

@qwwdfsad
Copy link
Collaborator

You can ask @mshishkina to rebase kotlin-community/dev on develop, it will eventually appear there.
kotlin-community/dev is branch-protected from us, so we cannot do it on our own

@LouisCAD
Copy link
Contributor

What is kotlin-community/dev?

@ilya-g
Copy link
Member Author

ilya-g commented Jul 28, 2023

@LouisCAD it's a branch used to test kotlinx.coroutines build with the latest dev Kotlin compiler version

PavelPunegov pushed a commit that referenced this pull request Aug 8, 2023
Also, remove flag `kotlin.mpp.enableGranularSourceSetsMetadata` that has no effect anymore

(cherry picked from commit 5c4a252)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants