Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the IDEA debugger #3822

Merged
merged 2 commits into from
Jul 25, 2023
Merged

Fix the IDEA debugger #3822

merged 2 commits into from
Jul 25, 2023

Conversation

dkhalanskyjb
Copy link
Collaborator

PR #3746 introduced a bug due to which the IDEA coroutine debugger didn't run. See
https://youtrack.jetbrains.com/issue/KTIJ-26327

@dkhalanskyjb
Fix the IDEA debugger
5924ac2 
The PR #3746 introduced a bug due to which the IDEA coroutine
debugger didn't run. See
https://youtrack.jetbrains.com/issue/KTIJ-26327
@dkhalanskyjb
Copy link
Collaborator Author

When I do git checkout version-1.7.1, git checkout version-1.7.2, and git checkout fix-idea-debugger and start some test, 1.7.1 and fix-idea-debugger behave seemingly identically, but version-1.7.2 does not display any coroutines, instead replying "No coroutine information found." I think this means the fix did the trick.

qwwdfsad
qwwdfsad approved these changes Jul 24, 2023
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise looks good

kotlinx-coroutines-core/jvm/src/debug/internal/DebugProbesImpl.kt Show resolved Hide resolved
@dkhalanskyjb @qwwdfsad
Update kotlinx-coroutines-core/jvm/src/debug/internal/DebugProbesImpl.kt
5ff7bd0 
Co-authored-by: Vsevolod Tolstopyatov <qwwdfsad@gmail.com>
@dkhalanskyjb dkhalanskyjb merged commit 47f0a46 into develop Jul 25, 2023
@dkhalanskyjb dkhalanskyjb deleted the fix-idea-debugger branch July 25, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dkhalanskyjb @qwwdfsad