Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Callback is now called when the message view is dismissed. #152

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bluezen
Copy link

@Bluezen Bluezen commented May 12, 2014

At the moment documentation defines the callback like that that: "The block that should be executed, when the user dismissed the message by tapping on it or swiping it to the top".

Unfortunately right now callback is called only after the message view gets touched.

For my own use I prefer that the callback block gets called whenever the message view is dismissed, whatever is the way it has been dismissed.
Here is my quick proposition of a way to achieve this, not 100% sure if I have done it the best way though (for this purpose it might be a better idea to call the callback directly inside the view before it gets removed from parents...).

This pull request is related to question #139

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant