Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependence on the HexColors pod. #161

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Remove dependence on the HexColors pod. #161

wants to merge 3 commits into from

Conversation

onato
Copy link
Contributor

@onato onato commented May 31, 2014

I have removed this pod since it can be replaced by just a few lines of code.

Does anyone have objections?

@KrauseFx
Copy link
Owner

KrauseFx commented Jun 1, 2014

I guess that would be something for @mRs-, who is the developer of HexColors

@mRs-
Copy link
Collaborator

mRs- commented Jun 2, 2014

Why should we remove the pod? The Pod itself is just working fine. In all of my projects that are working with HexColors i would have doubled my code base…

@KrauseFx
Copy link
Owner

KrauseFx commented Jun 2, 2014

I agree with @mRs- here. It's an advantage to have a dependency to not pull the same code multiple times if it's already in the project

@onato
Copy link
Contributor Author

onato commented Jun 2, 2014

We should remove it because it is not required to achieve the goal of the project. The user of our library could be using a number of other libraries that do the same thing (quick count on cocoapods 7). At present we force them to also include HexColors.

You raise a good point though Marcus. We can simplify further by not using hex codes to define our colours and removing the category I added.

If the user want to use hex codes they should decide which library they want to use.

@KrauseFx
Copy link
Owner

KrauseFx commented Jun 2, 2014

What alternative to Hex codes would you use in our JSON configuration?

@onato
Copy link
Contributor Author

onato commented Jun 2, 2014

Sorry, an oversight, we need hex codes after all. However we should not tightly couple the project to another.

@cameronehrlich
Copy link

👍 because HexColors is now on version v2.3.0 and is outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants