Support Robot Dance Configuration #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support to read a config file /etc/trd.conf instead of hard-coding the volume labels into the source itself.
"confiured" -> "configured"
IanLee1521
reviewed
Oct 7, 2017
| @@ -33,6 +34,13 @@ then | |||
| exit 1 | |||
| fi | |||
|
|
|||
| if [[ ! -f "${config_file}" ]]; then | |||
There was a problem hiding this comment.
Two comments,
- This is going to be backwards incompatible as written now, since now you require the
config_filewhich didn't used to be. Would it be reasonable to fall back to defaulting to thetrd.conffile you have in this PR if there isn't a file at/etc/trd.conf? - You might want to update the user warning to include the path that it's trying to find. Something like
"Please ensure that the configuration file (${config_file}) exists."
There was a problem hiding this comment.
Thanks Ian. Good thoughts:
- Not sure how much we care about backwards incompatibility here as the volume labels were hard coded in. If we do care about it may do something like that, or allow the user to specify an alternate config on the command line.
- Definitely more useful for the user. Will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support to read a config file /etc/trd.conf instead of
hard-coding the volume labels into the source itself.