Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use smart pointers within Engine #6804

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Use smart pointers within Engine #6804

wants to merge 2 commits into from

Conversation

sakertooth
Copy link
Contributor

A small improvement that was discussed previously but little action was done about it. This did bring some surprising questions (does Engine::destroy even destroy anymore?), but I'll leave it for review.

@sakertooth
Copy link
Contributor Author

It seems that destruction of the Engine members is causing problems within the tests executable. Will draft until some solution is found.

@sakertooth sakertooth marked this pull request as draft August 22, 2023 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sakertooth