Add support for "factorysample:" prefix #7236
Conversation
Add support to upgrade files with `src` tags that are prefixed with "factorysample:".
src/core/DataFile.cpp
Outdated
| { | ||
| const QString original = prefix + originalName + "." + extension; | ||
| const QString replacement = prefix + originalName + " - " + bpm + " BPM." + extension; | ||
|
|
There was a problem hiding this comment.
Fixed with commit d1fa6dd which also fixes the "bassloopes" issue.
Fix projects that still reference files with the typo "bassloopes" in their name. The upgrade is implemented in its own method because it is unrelated to the BPM renaming even if it is technically very similar in its solution. Introduce the helper method `mapSrcAttributeInElementsWithResources` which replaces the `src` attribute in elements with resources (samples and AFP) if it can be found in a map. Remove hidden tabs.
|
@michaelgregorius You often do very explanative commit messages, which is very valuable. However, some of the commits in your PRs have long commit messages without newlines. |
|
@JohannesLorenz, a while ago I always made sure that my commit messages all had line breaks at around 74 characters. However, this makes it rather tedious to write commit messages depending on which editor is used, especially if text is changed a lot during writing. I am now of the opinion that it's rather a problem of the tools that display commit messages and that these tools should not make me jump through hoops just because some of them are inadequate to display the messages. The long lines are just different paragraphs when looked at with other tools. |
|
I don't know why this was stuck in the back burner for this long. The fixes doesn't look too bad either and people had confirmed the fix. I haven't tested it tho so would be better if someone who actually test give the opinion on it. Let's get done with the small PRs please. |
|
I have now merged this. It should be rather safe as it "only" upgrades files that are loaded but should have no effect on files that are written. So, if we found that the merge has led to problems then we should be able to revert it without causing more havoc. |
…#7236) ## Add support for "factorysample:" prefix Add support to upgrade files with `src` tags that are prefixed with "factorysample:". ## Fix "bassloopes" typo Fix projects that still reference files with the typo "bassloopes" in their name. The upgrade is implemented in its own method because it is unrelated to the BPM renaming even if it is technically very similar in its solution. Introduce the helper method `mapSrcAttributeInElementsWithResources` which replaces the `src` attribute in elements with resources (samples and AFP) if it can be found in a map.
…#7236) ## Add support for "factorysample:" prefix Add support to upgrade files with `src` tags that are prefixed with "factorysample:". ## Fix "bassloopes" typo Fix projects that still reference files with the typo "bassloopes" in their name. The upgrade is implemented in its own method because it is unrelated to the BPM renaming even if it is technically very similar in its solution. Introduce the helper method `mapSrcAttributeInElementsWithResources` which replaces the `src` attribute in elements with resources (samples and AFP) if it can be found in a map.
…#7236) ## Add support for "factorysample:" prefix Add support to upgrade files with `src` tags that are prefixed with "factorysample:". ## Fix "bassloopes" typo Fix projects that still reference files with the typo "bassloopes" in their name. The upgrade is implemented in its own method because it is unrelated to the BPM renaming even if it is technically very similar in its solution. Introduce the helper method `mapSrcAttributeInElementsWithResources` which replaces the `src` attribute in elements with resources (samples and AFP) if it can be found in a map.
Add support to upgrade files with
srctags that are prefixed withfactorysample:.Fix the problem for projects that still have "bassloopes" in their source files.
See #7186 for more details.