Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move as many headers as possible out of the include folder #7341

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Move all headers in gui/include that aren't used outside of gui

d5a98ad
Select commit
Loading
Failed to load commit list.
Open

Move as many headers as possible out of the include folder #7341

Move all headers in gui/include that aren't used outside of gui
d5a98ad
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor succeeded Jul 5, 2024 in 13s

186 issues fixed. 180 issues found.

Annotations

Check notice on line 461 in src/core/tracks/InstrumentTrack.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/tracks/InstrumentTrack.cpp#L461 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 498 in src/core/tracks/InstrumentTrack.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/tracks/InstrumentTrack.cpp#L498 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 683 in src/core/tracks/InstrumentTrack.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/tracks/InstrumentTrack.cpp#L683 

Redundant blank line at the start of a code block should be deleted. (whitespace/blank_line)

Check notice on line 995 in src/core/tracks/InstrumentTrack.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/tracks/InstrumentTrack.cpp#L882-L995 

Complex Method

Check notice on line 805 in src/core/tracks/InstrumentTrack.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/tracks/InstrumentTrack.cpp#L700-L805 

Complex Method

Check notice on line 466 in src/core/tracks/InstrumentTrack.cpp

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/tracks/InstrumentTrack.cpp#L322-L466 

Complex Method

Check notice on line 911 in src/core/include/BasicFilters.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/BasicFilters.h#L911 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 916 in src/core/include/BasicFilters.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/BasicFilters.h#L706-L916 

Complex Method

Check notice on line 705 in src/core/include/BasicFilters.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/BasicFilters.h#L341-L705 

Complex Method

Check notice on line 574 in src/gui/include/PianoRoll.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/gui/include/PianoRoll.h#L574 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 423 in src/core/include/AutomatableModel.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/AutomatableModel.h#L423 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 79 in src/core/include/AudioEngine.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/AudioEngine.h#L79 

"public:" should be preceded by a blank line. (whitespace/blank_line)

Check notice on line 80 in src/core/include/AudioEngine.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/AudioEngine.h#L80 

Do not leave a blank line after "public:". (whitespace/blank_line)

Check notice on line 325 in src/core/include/Oscillator.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/Oscillator.h#L325 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 166 in src/core/include/Oscillator.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/Oscillator.h#L166 

Consider using rand_r(...) instead of rand(...) for improved thread safety. (runtime/threadsafe_fn)

Check notice on line 135 in src/core/include/DspEffectLibrary.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/DspEffectLibrary.h#L135 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 193 in src/core/include/DspEffectLibrary.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/DspEffectLibrary.h#L193 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 339 in src/core/include/DspEffectLibrary.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/DspEffectLibrary.h#L339 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 290 in src/core/include/NotePlayHandle.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/NotePlayHandle.h#L290 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 177 in src/gui/include/AutomationEditor.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/gui/include/AutomationEditor.h#L177 

Do not leave a blank line after "private:". (whitespace/blank_line)

Check notice on line 256 in src/core/include/AutomationClip.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/AutomationClip.h#L256 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 319 in src/core/include/InstrumentTrack.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/InstrumentTrack.h#L319 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 199 in src/gui/FileBrowser.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/gui/FileBrowser.h#L199 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 317 in src/gui/FileBrowser.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/gui/FileBrowser.h#L317 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)

Check notice on line 241 in src/core/include/Effect.h

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/core/include/Effect.h#L241 

Redundant blank line at the end of a code block should be deleted. (whitespace/blank_line)
View more details on codefactor.io