-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define fpp_t
and f_cnt_t
to be of size_t
#7363
Conversation
fpp_t
and f_cnt_t
with size_t
fpp_t
and f_cnt_t
with size_t
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor suggestions. The style changes seem to be too much so feel free to just resolve what I pointed out and neglect the rest
Also, you added mingw-std-threads
back in. Minor oversight.
Not an oversight, I just don't know how to fix it. This branch does not have |
Delete the submodule folder manually and commit |
Oh nevermind you're totally right, I added it in somehow 🤔. |
That seems to be the reason for ci fail too |
Also, I'm not going to worry about style for this PR. For these kind of PRs that span across many files, its far too time consuming to format each of the changes. |
Alright then |
83a75fe
to
aa89203
Compare
They're the same type, just a different name, so there's no concern about mixing them up. I'm also not sure how using plain A smaller change, simply redefining |
I figured that developers currently are more familiar with specifying
Yeah, this is easier to do. I will do that instead and define them as |
670234c
to
810f0c7
Compare
fpp_t
and f_cnt_t
with size_t
fpp_t
and f_cnt_t
to be of size_t
I just realized we already have some code now that uses |
You still didn't remove the submodule 😅 |
I did. It's not here anymore. |
This reverts commit 8e40921.
Nevermind, since I'm not worrying about replacing |
Co-authored-by: Dominic Clark <mrdomclark@gmail.com>
Defines
fpp_t
andf_cnt_t
to be ofsize_t
. Most of the codebase usedfpp_t
to represent the size of an array of sample frames, which is incorrect, given thatfpp_t
was only 16 bits when sizes greater than32767
are very possible.There were discussions about using
std::size_t
, but I left it assize_t
so that it can be adopted a bit easier in the code, and not end up in a situation where we mix upstd::size_t
andsize_t
.