Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove term "blacklist" #7365

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

JohannesLorenz
Copy link
Contributor

@JohannesLorenz JohannesLorenz commented Jul 3, 2024

About the PR:

  • We use "blocked" as an abstract term, when there may be different reasons
  • If there is a concrete reason, we use a more concrete word like "unstable" or "not useful"
  • Double negations like "don't block" or "block unstable" are avoided

Besides this, this PR

  • Lets Lv2Manager hide the full std::set of plugin URIs
  • Fixes occurences of "BuffersizeLessThan32" - it is less or equal
  • Moves enableBlockedPlugins from Engine to ConfigManager

About the PR:

* We use "blocked" as an abstract term, when there may be different reasons
* If there is a concrete reason, we use a more concrete word like "unstable"
  or "not useful"
* Double negations like "don't block" or "block unstable" are avoided

Besides this, this PR

* Lets `Lv2Manager` hide the full `std::set` of plugin URIs
* Fixes occurences of "BuffersizeLessThan32" - it is less or equal
src/core/Engine.cpp Outdated Show resolved Hide resolved
@JohannesLorenz JohannesLorenz merged commit f2c815b into LMMS:master Jul 8, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants