-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zooming and sliding of the waveform view in AudioFileProcessor #7377
Fix zooming and sliding of the waveform view in AudioFileProcessor #7377
Conversation
can you fully fix it? with help from @michaelgregorius |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some minor thoughts
I would appreciate some help, but it isn't strictly needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small code suggestions here. Will try to test later.
I'll test this ASAP. |
When looking at this initially, it seems perfectly fine. I'll install it on my system at test it, you'll have more opinions from me in a few days. @Rossmaxx says some users mentioned it didn't solve the issue for them. Would you like any info regarding my system and building process? |
I'm hearing about this for the first time. I've changed how thing work so I'm not sure what is exactly the issue they are experiencing. I would like to hear info about what is the problem firstly. Thank you for reviewing it and communicating the issue. I would like to know how the testing goes. |
@szeli1, what do the second and third point mean? I would like to be sure I've tested them, so if you could elaborate on them more, that would be terrific! |
In other words: |
Oh, no, not that, that's something @Rossmaxx mentioned on Discord. I'm talking about "sliding the waveshape" and "zooming in". I would like you to elaborate on those in a bit more detail, so I can make sure I have tested them properly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't tested it, but the changes look sane.
Just tested it, it works a lot better now 👍. We should still address the outstanding comments if possible before merge though. |
Dragging the waveshape left and right or up and down. |
LGTM, we've discussed the fact that sometimes sliding happens instead of zooming, and vice versa, but I believe this is the minor mouse/trackpad twitches, so it's fine. If you still want to work on that, I'm more than willing to test it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far.
closes #7375
fixes partially #7074
I have fixed some issues with the graph:
The sliding and the zooming was separated in mouseMoveEvent, if the user starts sliding or zooming, they will no longer be able to zoom or slide until next mouse press.