Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add input dialog to the mixer channel LCD spin box #7399

Merged
merged 2 commits into from
Aug 11, 2024

Conversation

szeli1
Copy link
Contributor

@szeli1 szeli1 commented Jul 27, 2024

Added InputDialog for the mixer channel widget.
This will allow better control when assigning mixer channels for instruments

@sakertooth sakertooth changed the title MixerChannelLcdSpinBox added inputdialog Add input dialog to the MixerChannel LCD spin box Aug 5, 2024
@sakertooth sakertooth changed the title Add input dialog to the MixerChannel LCD spin box Add input dialog to the mixer channel LCD spin box Aug 5, 2024
Copy link
Contributor

@sakertooth sakertooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are many places where we also need to open a dialog that selects a value from some range. We should probably remove this duplication in the future.

src/gui/widgets/MixerChannelLcdSpinBox.cpp Outdated Show resolved Hide resolved
src/gui/widgets/MixerChannelLcdSpinBox.cpp Show resolved Hide resolved
@sakertooth sakertooth merged commit bda1a9c into LMMS:master Aug 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants