Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDL driver's input and output device configuration via combo box #7421

Merged
merged 12 commits into from
Aug 10, 2024

Commits on Aug 3, 2024

  1. Enable configuration of input device for SDL

    Up to now the SDL audio driver attempted to use the default recording
    device. This might not be what users want or expect, especially since the
    actually used device is not visible anywhere. So if recording does not
    work for the users they have no way to find out what's wrong.
    
    Extend the settings screen of the SDL driver with a combo box that allows
    to select the input device to be used. Store the selected device name in
    a new attribute called "inputdevice" in the "audiosdl" section of the
    configuration file.
    
    Use the information from the configuration when attempting to inialize
    the input device. Fall back to the default device if that does not work.
    
    (cherry picked from commit 33139b9)
    michaelgregorius committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    20298f2 View commit details
    Browse the repository at this point in the history
  2. Provide a setting for system default input

    Provide the setting "[System Default]" which instructs the SDL driver to
    use the default device of the system as the input device. In the
    configuration file this option is represented as an empty string. This
    should play well with the current existing configuration of the users.
    
    (cherry picked from commit 29c43c2)
    michaelgregorius committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    630c659 View commit details
    Browse the repository at this point in the history
  3. Configuration of output device for SDL

    Let users configure the output device that's used by the SDL driver.
    Code-wise the implementation is very similar to the input device
    configuration.
    
    Use a `QComboBox` instead of a `QLineEdit` for `m_device` and rename it
    to `m_playbackDeviceComboBox`.
    
    Rename `s_defaultInputDevice` to `s_systemDefaultDevice` because it is
    used in the context of playback and input devices.
    
    (cherry picked from commit 1ab45e4)
    michaelgregorius committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    6ded294 View commit details
    Browse the repository at this point in the history
  4. Ensure label visibility

    Make sure that labels are always shown by setting the row wrap policy of
    the form layout to wrap long rows.
    
    (cherry picked from commit a123d0e)
    michaelgregorius committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    94b43f5 View commit details
    Browse the repository at this point in the history
  5. Rename "Device"

    Rename "Device" to "Playback device" to make clear what the setting
    refers to.
    
    (cherry picked from commit 1f0cda4)
    michaelgregorius committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    a2eea71 View commit details
    Browse the repository at this point in the history
  6. Remove repeated strings

    Introduce const expressions to get rid of repeated strings with a risk
    of typos.
    
    (cherry picked from commit f9ea970)
    michaelgregorius committed Aug 3, 2024
    Configuration menu
    Copy the full SHA
    4111c93 View commit details
    Browse the repository at this point in the history

Commits on Aug 4, 2024

  1. Apply some more changes

    Apply some more changes that have been made to `AudioSdl` in the
    recording branch.
    michaelgregorius committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    2f1736a View commit details
    Browse the repository at this point in the history
  2. Conditional ternary operator

    Also use a conditional ternary operator for the input device setup.
    michaelgregorius committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    268427d View commit details
    Browse the repository at this point in the history
  3. Methods for population of combo boxes

    Move the population of the input and playback device combo boxes into
    the methods `populatePlaybackDeviceComboBox` and
    `populateInputDeviceComboBox`.
    michaelgregorius committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    5b2f342 View commit details
    Browse the repository at this point in the history
  4. Sort devices in combo box

    Sort the devices names alphabetically in the input and playback combo
    boxes. The default devices is always shown as the first entry.
    michaelgregorius committed Aug 4, 2024
    Configuration menu
    Copy the full SHA
    459fe8a View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2024

  1. Code review fixes

    Use `AudioDeviceSetupWidget` instead of `QObject` to translate "[System
    Default]".
    
    Fix copy/paste error in comment.
    michaelgregorius committed Aug 10, 2024
    Configuration menu
    Copy the full SHA
    f78e147 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f3b284b View commit details
    Browse the repository at this point in the history