-
-
Notifications
You must be signed in to change notification settings - Fork 995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SDL driver's input and output device configuration via combo box #7421
Merged
michaelgregorius
merged 12 commits into
LMMS:master
from
michaelgregorius:SDLDriverConfigCombobox
Aug 10, 2024
Merged
SDL driver's input and output device configuration via combo box #7421
michaelgregorius
merged 12 commits into
LMMS:master
from
michaelgregorius:SDLDriverConfigCombobox
Aug 10, 2024
Commits on Aug 3, 2024
-
Enable configuration of input device for SDL
Up to now the SDL audio driver attempted to use the default recording device. This might not be what users want or expect, especially since the actually used device is not visible anywhere. So if recording does not work for the users they have no way to find out what's wrong. Extend the settings screen of the SDL driver with a combo box that allows to select the input device to be used. Store the selected device name in a new attribute called "inputdevice" in the "audiosdl" section of the configuration file. Use the information from the configuration when attempting to inialize the input device. Fall back to the default device if that does not work. (cherry picked from commit 33139b9)
Configuration menu - View commit details
-
Copy full SHA for 20298f2 - Browse repository at this point
Copy the full SHA 20298f2View commit details -
Provide a setting for system default input
Provide the setting "[System Default]" which instructs the SDL driver to use the default device of the system as the input device. In the configuration file this option is represented as an empty string. This should play well with the current existing configuration of the users. (cherry picked from commit 29c43c2)
Configuration menu - View commit details
-
Copy full SHA for 630c659 - Browse repository at this point
Copy the full SHA 630c659View commit details -
Configuration of output device for SDL
Let users configure the output device that's used by the SDL driver. Code-wise the implementation is very similar to the input device configuration. Use a `QComboBox` instead of a `QLineEdit` for `m_device` and rename it to `m_playbackDeviceComboBox`. Rename `s_defaultInputDevice` to `s_systemDefaultDevice` because it is used in the context of playback and input devices. (cherry picked from commit 1ab45e4)
Configuration menu - View commit details
-
Copy full SHA for 6ded294 - Browse repository at this point
Copy the full SHA 6ded294View commit details -
Make sure that labels are always shown by setting the row wrap policy of the form layout to wrap long rows. (cherry picked from commit a123d0e)
Configuration menu - View commit details
-
Copy full SHA for 94b43f5 - Browse repository at this point
Copy the full SHA 94b43f5View commit details -
Rename "Device" to "Playback device" to make clear what the setting refers to. (cherry picked from commit 1f0cda4)
Configuration menu - View commit details
-
Copy full SHA for a2eea71 - Browse repository at this point
Copy the full SHA a2eea71View commit details -
Introduce const expressions to get rid of repeated strings with a risk of typos. (cherry picked from commit f9ea970)
Configuration menu - View commit details
-
Copy full SHA for 4111c93 - Browse repository at this point
Copy the full SHA 4111c93View commit details
Commits on Aug 4, 2024
-
Apply some more changes that have been made to `AudioSdl` in the recording branch.
Configuration menu - View commit details
-
Copy full SHA for 2f1736a - Browse repository at this point
Copy the full SHA 2f1736aView commit details -
Also use a conditional ternary operator for the input device setup.
Configuration menu - View commit details
-
Copy full SHA for 268427d - Browse repository at this point
Copy the full SHA 268427dView commit details -
Methods for population of combo boxes
Move the population of the input and playback device combo boxes into the methods `populatePlaybackDeviceComboBox` and `populateInputDeviceComboBox`.
Configuration menu - View commit details
-
Copy full SHA for 5b2f342 - Browse repository at this point
Copy the full SHA 5b2f342View commit details -
Sort the devices names alphabetically in the input and playback combo boxes. The default devices is always shown as the first entry.
Configuration menu - View commit details
-
Copy full SHA for 459fe8a - Browse repository at this point
Copy the full SHA 459fe8aView commit details
Commits on Aug 10, 2024
-
Use `AudioDeviceSetupWidget` instead of `QObject` to translate "[System Default]". Fix copy/paste error in comment.
Configuration menu - View commit details
-
Copy full SHA for f78e147 - Browse repository at this point
Copy the full SHA f78e147View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3b284b - Browse repository at this point
Copy the full SHA f3b284bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.