-
-
Notifications
You must be signed in to change notification settings - Fork 994
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FileDialog: Add URLs only if they're not present #7430
base: master
Are you sure you want to change the base?
Conversation
…restore old sidebar state on exit
I realized that the user may also want to add bookmarks inside LMMS. This PR would've made it impossible to do that because the the sidebar will always revert to the old state when it exists. The steps needed to scan for new bookmarks are too complicated and unnecessary for now, so I'm going to remove the 2nd task of this PR. |
Would switching to using just the |
@sakertooth It could be possible. However LMMS's FileDialog currently has some custom methods. I can try to migrate to QFileDialog but this is a bit out of the scope of this PR at the moment |
…on't revert sidebar to old state
As #7405 states, all user-saved bookmarks/URLs on the sidebar is lost when LMMS launches the FileDialog, which affects other QT apps that share the same file dialog in the system.
This does:
2. Store a list of the old URLs and restore them when the destructor of FileDialog is called.Removed, see reasonI initially wanted to have FileDialog(...) open the sidebar as is, but that would mean removing the implementation the previous contributor intended.