Remove support for SDL1 #7443
Merged
Remove support for SDL1 #7443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the fallback code in `CMakeLists.txt`. Remove the specific `LMMS_HAVE_SDL2` define. Remove several ifdefs which check for SDL2 or SDL1. Remove all code related to SDL1.
DomClark
reviewed
Aug 10, 2024
Keep the message that's shown when SDL is wanted but not found. Just print "OK" if SDL is found.
DomClark
approved these changes
Aug 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the fallback code in
CMakeLists.txt. Remove the specificLMMS_HAVE_SDL2define.Remove several ifdefs which check for SDL2 or SDL1. Remove all code related to SDL1.