Fix up PortAudio backend #7444
Open
Fix up PortAudio backend #7444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If PortAudio is not found, then nothing should be defined here anyways.
We should do this for any of the other applicable audio devices in the future (to encourage separation of GUI and Core).
Returning paComplete from the audio callback, as well as using our own stop variable may conflict in complex ways. One such example is if the stop boolean is set and the device is required to read the nullptr buffer when the audio FIFO thread is closing. Also, PortAudio's says using paComplete and paAbort is an alternative technique to calling Pa_StopStream, so using both isn't necessary and thus avoids streams being stopped or started unexpectedly.
Made a misunderstanding. Pa_StopStream requires that we return paComplete when we are done to tell it that no more new buffers are being rendered for now and it can play any pending audio buffers.
No need for AudioEngine::clip since PortAudio already clips the signal for us.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a latency bug caused by suggesting the wrong (supposedly?) latency to PortAudio, which caused stuttering on certain occasions. We now fetch an appropriate latency for the device using
PaDeviceInfo::defaultLowInputLatencyandPaDeviceInfo::defaultLowOutputLatency.Removes the
m_stoppedvariable and stops the stream using only a return ofpaCompletein the audio callback and a call toPa_StopStreamto avoid potential conflicts.Also cleaned up the code a bit. Moved the GUI specific widget code in the GUI namespace, completely removed the PortAudio v18 code, among other things.
Testing on Windows will be appreciated. I am curious to see if this fixed any issues relating to PortAudio for anyone else.