fix(GitHubSource): borrowing

Co-authored-by: Filip Tibell <filip.tibell@gmail.com>
LPGhatguy · Sep 5, 2022 · c106675 · c106675
1 parent 3437ec6
commit c106675
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/tool_source/github.rs b/src/tool_source/github.rs
@@ -23,10 +23,10 @@ pub struct GitHubSource {
 }
 
 impl GitHubSource {
-    pub fn new(auth: Option<AuthManifest>) -> Self {
+    pub fn new(auth: Option<&AuthManifest>) -> Self {
         Self {
             client: Client::new(),
-            token: auth.map(|t| t.github).flatten()
+            token: auth.and_then(|t| t.github.clone())
         }
     }
 

diff --git a/src/tool_storage.rs b/src/tool_storage.rs
@@ -159,7 +159,7 @@ impl ToolStorage {
         log::info!("Installing tool: {}", spec);
 
         log::debug!("Fetching GitHub releases...");
-        let github = self.github.get_or_init(|| GitHubSource::new(self.auth));
+        let github = self.github.get_or_init(|| GitHubSource::new(self.auth.as_ref()));
         let mut releases = github.get_all_releases(spec.name())?;
         releases.sort_by(|a, b| a.version.cmp(&b.version).reverse());
 
@@ -237,7 +237,7 @@ impl ToolStorage {
         log::info!("Installing tool: {id}");
 
         log::debug!("Fetching GitHub release...");
-        let github = self.github.get_or_init(|| GitHubSource::new(self.auth));
+        let github = self.github.get_or_init(|| GitHubSource::new(self.auth.as_ref()));
         let release = github.get_release(id)?;
 
         let mut compatible_assets = self.get_compatible_assets(&release);