Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support self-install on Unix #12

Closed
wants to merge 2 commits into from
Closed

Conversation

Yumacide
Copy link
Contributor

@Yumacide Yumacide commented May 24, 2022

Closes #10.

@LPGhatguy
Copy link
Owner

I updated your description, but you need to put closing keywords in the main description in order for GitHub to pick them up. You can edit your PR at any time!

@LPGhatguy
Copy link
Owner

This PR appears to be taken verbatim from the Rustup source code. In the future, when contributing PRs to any project, you should include attribution for code that you did not write both in your PR body and in the source code, following the original code's license.

The upstream project, Rustup, is dual-licensed under the MIT and Apache-2.0 licenses. While it is possible to attribute this code to them and include an exception that some code in Aftman is owned by the authors of Rustup, I would rather keep this entire project under the same license.

@Yumacide
Copy link
Contributor Author

Rustup's README says: "Licensed under either of Apache 2.0 or MIT at your option." so you can keep the MIT license, but I should indeed have added some attribution. Thanks!

@LPGhatguy
Copy link
Owner

Keeping the MIT license is one thing, but I would like to keep all of the code under this project under the same copyright notice without additional attribution or asterisks. Instead of taking this code wholesale from Rustup, I would rather we write a simpler solution that fits in with the codebase and stays owned solely by Aftman contributors.

@LPGhatguy
Copy link
Owner

Replaced by #16.

@LPGhatguy LPGhatguy closed this Jul 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Supporting adding to PATH on non-Windows platforms
2 participants